rdblue commented on code in PR #460: URL: https://github.com/apache/parquet-format/pull/460#discussion_r1813711255
########## LogicalTypes.md: ########## @@ -563,6 +563,23 @@ defined by the [BSON specification][bson-spec]. The sort order used for `BSON` is unsigned byte-wise comparison. +### VARIANT + +`VARIANT` is used for a Variant value. It must annotate a group. The group must +contain a `binary` field named `metadata`, and a `binary` field named `value`. +The `VARIANT` annotated group can be used to store either an unshredded Variant +value, or a shredded Variant value. + +* The top level must be a group annotated with `VARIANT` that contains a + `binary` field named `metadata`, and a `binary` field named `value`. +* Additional fields which start with `_` (underscore) can be ignored. +* If `metadata` and `value` are the only fields in the group, then the group + is an unshredded Variant value. The `metadata` and `value` fields are + interpreted as an encoded Variant value as defined by the + [Variant binary encoding specification](VariantEncoding.md). +* If the group contains additional fields, it is a shredded Variant, and must + adhere to the scheme detailed in the [Variant shredding specification](VariantShredding.md). Review Comment: Yeah, that's fair. I think this is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
