rdblue commented on code in PR #460: URL: https://github.com/apache/parquet-format/pull/460#discussion_r1813718891
########## LogicalTypes.md: ########## @@ -563,6 +563,23 @@ defined by the [BSON specification][bson-spec]. The sort order used for `BSON` is unsigned byte-wise comparison. +### VARIANT + +`VARIANT` is used for a Variant value. It must annotate a group. The group must +contain a `binary` field named `metadata`, and a `binary` field named `value`. +The `VARIANT` annotated group can be used to store either an unshredded Variant +value, or a shredded Variant value. + +* The top level must be a group annotated with `VARIANT` that contains a + `binary` field named `metadata`, and a `binary` field named `value`. Review Comment: Yes, I think that it can be required if the Variant is not shredded. That does save a bit of space. For this doc, that means we should mention that when there is no shredding, the `value` is required and it is optional when shredded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
