rdblue commented on code in PR #460: URL: https://github.com/apache/parquet-format/pull/460#discussion_r1813735650
########## LogicalTypes.md: ########## @@ -563,6 +563,41 @@ defined by the [BSON specification][bson-spec]. The sort order used for `BSON` is unsigned byte-wise comparison. +### VARIANT + +`VARIANT` is used for a Variant value. It must annotate a group. The group must +contain a `binary` field named `metadata`, and a `binary` field named `value`. Review Comment: Ah, you're right. The type is `BYTE_ARRAY` in thrift but `binary` in actual type definitions. I think that `binary` is more clear, but we should mention that they are synonyms at a minimum. How about this? > The group must contain a field named `metadata` and a field named `value`. Both fields must have type `binary`, which is also called `BYTE_ARRAY` in the Parquet thrift definition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
