gene-db commented on code in PR #460: URL: https://github.com/apache/parquet-format/pull/460#discussion_r1815378011
########## LogicalTypes.md: ########## @@ -563,6 +563,41 @@ defined by the [BSON specification][bson-spec]. The sort order used for `BSON` is unsigned byte-wise comparison. +### VARIANT + +`VARIANT` is used for a Variant value. It must annotate a group. The group must +contain a `binary` field named `metadata`, and a `binary` field named `value`. Review Comment: Sounds good! Updated. ########## LogicalTypes.md: ########## @@ -563,6 +563,23 @@ defined by the [BSON specification][bson-spec]. The sort order used for `BSON` is unsigned byte-wise comparison. +### VARIANT + +`VARIANT` is used for a Variant value. It must annotate a group. The group must +contain a `binary` field named `metadata`, and a `binary` field named `value`. +The `VARIANT` annotated group can be used to store either an unshredded Variant +value, or a shredded Variant value. + +* The top level must be a group annotated with `VARIANT` that contains a + `binary` field named `metadata`, and a `binary` field named `value`. +* Additional fields which start with `_` (underscore) can be ignored. Review Comment: I see. I was worried that future evolution could break existing stored Variants, but simply adding a new field with optional or redundant semantics achieves the same compatibility story. This is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
