emkornfield commented on code in PR #3396:
URL: https://github.com/apache/parquet-java/pull/3396#discussion_r2836933662
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordWriter.java:
##########
@@ -108,14 +147,27 @@ public ParquetMetadata getFooter() {
}
private void initStore() {
- ColumnChunkPageWriteStore columnChunkPageWriteStore = new
ColumnChunkPageWriteStore(
- compressor,
- schema,
- props.getAllocator(),
- props.getColumnIndexTruncateLength(),
- props.getPageWriteChecksumEnabled(),
- fileEncryptor,
- rowGroupOrdinal);
+ ColumnChunkPageWriteStore columnChunkPageWriteStore;
+ if (codecFactory != null) {
Review Comment:
Is it possible to create a default codecFactory to avoid the if/else block
below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
