rahil-c commented on code in PR #3396:
URL: https://github.com/apache/parquet-java/pull/3396#discussion_r2838441484
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordWriter.java:
##########
@@ -108,14 +147,27 @@ public ParquetMetadata getFooter() {
}
private void initStore() {
- ColumnChunkPageWriteStore columnChunkPageWriteStore = new
ColumnChunkPageWriteStore(
- compressor,
- schema,
- props.getAllocator(),
- props.getColumnIndexTruncateLength(),
- props.getPageWriteChecksumEnabled(),
- fileEncryptor,
- rowGroupOrdinal);
+ ColumnChunkPageWriteStore columnChunkPageWriteStore;
+ if (codecFactory != null) {
Review Comment:
In my mind I thought the if/else would be simpler, since there are callers
that will not be providing/using the codec factory so not sure if having the
default codec there would make sense, such as the following:
https://github.com/apache/parquet-java/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetRecordWriter.java#L106
Let me know though if you think we should still pursue the default code
factory approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
