rahil-c commented on code in PR #3396:
URL: https://github.com/apache/parquet-java/pull/3396#discussion_r2838254167
##########
parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java:
##########
@@ -756,6 +771,32 @@ public Builder withSizeStatisticsEnabled(String
columnPath, boolean enabled) {
return this;
}
+ /**
+ * Set the compression codec for the columns not specified by
+ * {@link #withCompressionCodec(String, CompressionCodecName)}.
+ *
+ * @param codecName the compression codec to use by default
+ * @return this builder for method chaining.
+ */
+ public Builder withCompressionCodec(CompressionCodecName codecName) {
Review Comment:
There is an existing api at the Parquet writer builder class:
https://github.com/apache/parquet-java/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java#L567
However there is not an api within this properties class, which we use this
class in a couple of places to pass the column's compression.
In terms of the naming I am ok with that suggestion, however I noticed the
pattern for the APIs to not prefix with *Default*, even when setting a default
value:
https://github.com/apache/parquet-java/blob/master/parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java#L484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
