emkornfield commented on code in PR #3396:
URL: https://github.com/apache/parquet-java/pull/3396#discussion_r2836939583
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetRecordWriter.java:
##########
@@ -201,15 +201,11 @@ public ParquetRecordWriter(
MemoryManager memoryManager,
Configuration conf) {
this.codecFactory = new CodecFactory(conf, props.getPageSizeThreshold());
+ // Ensure the default compression codec from ParquetOutputFormat is set in
props
+ ParquetProperties propsWithCodec =
+ ParquetProperties.copy(props).withCompressionCodec(codec).build();
Review Comment:
does risk overwriting an already set compression codec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
