gjacoby126 commented on a change in pull request #517: PHOENIX-5211 Consistent
Immutable Global Indexes for Non-Transactiona…
URL: https://github.com/apache/phoenix/pull/517#discussion_r296917686
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
##########
@@ -294,13 +295,29 @@ private static boolean isEmptyKeyValue(PTable table,
ColumnReference ref) {
.getLength()) == 0);
}
+
+ public static boolean isGlobalIndexCheckerEnabled(PhoenixConnection
connection, PName index)
+ throws SQLException {
+ TableDescriptor desc = desc =
connection.getQueryServices().getTableDescriptor(index.getBytes());
Review comment:
This is called from generateIndexData which will be high-traffic. What are
the perf implications of grabbing the table descriptor very frequently, and do
we need caching?
Looks like this creates an HTable each time which will in turn make a remote
call to the Master each time
@gokceni @kadirozde
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
