gjacoby126 commented on a change in pull request #517: PHOENIX-5211 Consistent
Immutable Global Indexes for Non-Transactiona…
URL: https://github.com/apache/phoenix/pull/517#discussion_r296905515
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexIT.java
##########
@@ -259,7 +279,150 @@ private void assertIndexMutations(Connection conn)
throws SQLException {
(transactionProvider != null &&
transactionProvider.isUnsupported(Feature.MAINTAIN_LOCAL_INDEX_ON_SERVER)),
iterator.hasNext());
}
-
+
+ private void createAndPopulateTableAndIndexForConsistentIndex(Connection
conn, String tableName, String indexName, int numOfRowsToInsert)
+ throws Exception {
+ String ddl = "CREATE TABLE " + TABLE_NAME + TestUtil.TEST_TABLE_SCHEMA
+ tableDDLOptions;
Review comment:
@gokceni - passing in a tableName parameter but not using it here, since the
create statement is using the static value. Even if we need the static value to
be set for some other reason, (and I agree with @priyankporwal that we ideally
shouldn't need that), within this function we should be consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
