gjacoby126 commented on a change in pull request #517: PHOENIX-5211 Consistent
Immutable Global Indexes for Non-Transactiona…
URL: https://github.com/apache/phoenix/pull/517#discussion_r296915301
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -911,7 +911,8 @@ private void addCoprocessors(byte[] tableName,
TableDescriptorBuilder builder, P
QueryServicesOptions.DEFAULT_INDEX_REGION_OBSERVER_ENABLED);
if (tableType == PTableType.INDEX && !isTransactional) {
- if (globalIndexerEnabled &&
!newDesc.hasCoprocessor(GlobalIndexChecker.class.getName())) {
+ if (globalIndexerEnabled &&
!newDesc.hasCoprocessor(GlobalIndexChecker.class.getName()) &&
+
!isLocalIndexTable(builder.build().getColumnFamilyNames())) {
Review comment:
nit: can use newDesc for the TableDescriptor rather than using
builder.build() to reconstruct it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
