gjacoby126 commented on a change in pull request #517: PHOENIX-5211 Consistent
Immutable Global Indexes for Non-Transactiona…
URL: https://github.com/apache/phoenix/pull/517#discussion_r296918487
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java
##########
@@ -877,8 +875,12 @@ public static void dumpTable(Table table) throws
IOException {
}
public static int getRawRowCount(Table table) throws IOException {
+ return getRawRowCount(table, true);
+ }
+
+ public static int getRawRowCount(Table table, boolean isRaw) throws
IOException {
Review comment:
nit: Seems a little odd to have a function named getRawRowCount that doesn't
do a raw scan if you pass in false. (As opposed to having a getRowCount
funciton with an isRaw parameter.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
