[ https://issues.apache.org/jira/browse/PHOENIX-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014734#comment-17014734 ]
Sandeep Guggilam commented on PHOENIX-5636: ------------------------------------------- [~abhishek.chouhan] and I had a look . Here are our thoughts: # Extract out the main logic of checking the version compatibility into a different function. Probably reuse the isCompatible function ? # The function can check for all conditions populating a passed-in buffer with the right error message # The function can be unit tested as well for all scenarios ( right versions, different minor versions, same major / different major versions etc ) # For major version check , it will be good to have client == server rather than client >= server > Improve the error message when client connects to server with higher major > version > ---------------------------------------------------------------------------------- > > Key: PHOENIX-5636 > URL: https://issues.apache.org/jira/browse/PHOENIX-5636 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.15.0 > Reporter: Sandeep Guggilam > Assignee: Christine Feng > Priority: Minor > Labels: beginner, newbie > Fix For: 4.15.1 > > Attachments: PHOENIX-5636.master.v1.patch, > PHOENIX-5636.master.v2.patch, PHOENIX-5636.master.v3.patch > > Time Spent: 20m > Remaining Estimate: 0h > > When a 4.14 client connects to a 5.0 server, it errors out saying " Outdated > jars. Newer Phoenix clients can't communicate with older Phoenix servers" > It should probably error out with "Major version of client is less than that > of the server" -- This message was sent by Atlassian Jira (v8.3.4#803005)