[
https://issues.apache.org/jira/browse/PHOENIX-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016212#comment-17016212
]
Sandeep Guggilam commented on PHOENIX-5636:
-------------------------------------------
[~christine.feng] Overall the logic is good, but a few minor things:
# I see "String" import from some other package, this might be unintentional ?
# You don't need the isIncompatible and isMajorIncompatible variables as you
already have the error code and the buf message to create the SQLException
# rename "buf" as "errorCode"
# As mentioned by [~ckulkarni], it will be good to print the server and client
version as part of the error messages
> Improve the error message when client connects to server with higher major
> version
> ----------------------------------------------------------------------------------
>
> Key: PHOENIX-5636
> URL: https://issues.apache.org/jira/browse/PHOENIX-5636
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0
> Reporter: Sandeep Guggilam
> Assignee: Christine Feng
> Priority: Minor
> Labels: beginner, newbie
> Fix For: 4.15.1
>
> Attachments: PHOENIX-5636.master.v1.patch,
> PHOENIX-5636.master.v2.patch, PHOENIX-5636.master.v3.patch,
> PHOENIX-5636.master.v4.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a 4.14 client connects to a 5.0 server, it errors out saying " Outdated
> jars. Newer Phoenix clients can't communicate with older Phoenix servers"
> It should probably error out with "Major version of client is less than that
> of the server"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
