[ https://issues.apache.org/jira/browse/PHOENIX-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016463#comment-17016463 ]
Hadoop QA commented on PHOENIX-5636: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12991052/PHOENIX-5636.master.v5.patch against master branch at commit 52e5e2ae320be9be649188b0208d3b05cbe7bedc. ATTACHMENT ID: 12991052 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + if (Integer.parseInt(errorCode.toString()) == SQLExceptionCode.OUTDATED_JARS.getErrorCode()) { + + "Phoenix servers. " + displayClientandServerVersions(serverJarVersion) + errorMessage.append("Major version of client is less than that of the server. " + displayClientandServerVersions(serverJarVersion)); + if (Integer.parseInt(errorCode.toString()) == SQLExceptionCode.OUTDATED_JARS.getErrorCode()) { + throw new SQLExceptionInfo.Builder(SQLExceptionCode.OUTDATED_JARS).setMessage(errorMessage.toString()).build().buildException(); + throw new SQLExceptionInfo.Builder(SQLExceptionCode.INCOMPATIBLE_CLIENT_SERVER_JAR).setMessage(errorMessage.toString()).build().buildException(); + String clientVersion = PHOENIX_MAJOR_VERSION + "." + PHOENIX_MINOR_VERSION + "." + PHOENIX_PATCH_NUMBER; + String serverVersion = VersionUtil.decodeMajorVersion(MetaDataUtil.decodePhoenixVersion(serverJarVersion)) + "." + + VersionUtil.decodeMinorVersion(MetaDataUtil.decodePhoenixVersion(serverJarVersion)) + "." + + VersionUtil.decodePatchVersion(MetaDataUtil.decodePhoenixVersion(serverJarVersion)); {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3322//testReport/ Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3322//console This message is automatically generated. > Improve the error message when client connects to server with higher major > version > ---------------------------------------------------------------------------------- > > Key: PHOENIX-5636 > URL: https://issues.apache.org/jira/browse/PHOENIX-5636 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.15.0 > Reporter: Sandeep Guggilam > Assignee: Christine Feng > Priority: Minor > Labels: beginner, newbie > Fix For: 4.15.1 > > Attachments: PHOENIX-5636.master.v1.patch, > PHOENIX-5636.master.v2.patch, PHOENIX-5636.master.v3.patch, > PHOENIX-5636.master.v4.patch, PHOENIX-5636.master.v5.patch > > Time Spent: 20m > Remaining Estimate: 0h > > When a 4.14 client connects to a 5.0 server, it errors out saying " Outdated > jars. Newer Phoenix clients can't communicate with older Phoenix servers" > It should probably error out with "Major version of client is less than that > of the server" -- This message was sent by Atlassian Jira (v8.3.4#803005)