[
https://issues.apache.org/jira/browse/PHOENIX-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040505#comment-17040505
]
Hadoop QA commented on PHOENIX-5636:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12993947/PHOENIX-5636.master.v9.patch
against master branch at commit 28de55b5c79a5fc32dee97a59e5b4f528ca6dce6.
ATTACHMENT ID: 12993947
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ MetaDataUtil.ClientServerCompatibility compatibility =
MetaDataUtil.areClientAndServerCompatible(serverJarVersion);
+ if (compatibility.getErrorCode() ==
SQLExceptionCode.OUTDATED_JARS.getErrorCode()) {
+ errorMessage.append("Major version of client is less
than that of the server. " + getClientandServerVersions(serverJarVersion));
+ if (compatibility.getErrorCode() ==
SQLExceptionCode.OUTDATED_JARS.getErrorCode()) {
+ throw new
SQLExceptionInfo.Builder(SQLExceptionCode.OUTDATED_JARS).setMessage(errorMessage.toString()).build().buildException();
+ throw new
SQLExceptionInfo.Builder(SQLExceptionCode.INCOMPATIBLE_CLIENT_SERVER_JAR).setMessage(errorMessage.toString()).build().buildException();
+ String serverVersion =
VersionUtil.decodeMajorVersion(MetaDataUtil.decodePhoenixVersion(serverJarVersion))
+ "."
+ +
VersionUtil.decodeMinorVersion(MetaDataUtil.decodePhoenixVersion(serverJarVersion))
+ "."
+ +
VersionUtil.decodePatchVersion(MetaDataUtil.decodePhoenixVersion(serverJarVersion));
+ return "Client version: " + MetaDataProtocol.CURRENT_CLIENT_VERSION +
". Server version: " + serverVersion + ".";
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3459//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3459//console
This message is automatically generated.
> Improve the error message when client connects to server with higher major
> version
> ----------------------------------------------------------------------------------
>
> Key: PHOENIX-5636
> URL: https://issues.apache.org/jira/browse/PHOENIX-5636
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0
> Reporter: Sandeep Guggilam
> Assignee: Christine Feng
> Priority: Minor
> Labels: beginner, newbie
> Fix For: 4.15.1
>
> Attachments: PHOENIX-5636.master.v1.patch,
> PHOENIX-5636.master.v2.patch, PHOENIX-5636.master.v3.patch,
> PHOENIX-5636.master.v4.patch, PHOENIX-5636.master.v5.patch,
> PHOENIX-5636.master.v6.patch, PHOENIX-5636.master.v7.patch,
> PHOENIX-5636.master.v8.patch, PHOENIX-5636.master.v9.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When a 4.14 client connects to a 5.0 server, it errors out saying " Outdated
> jars. Newer Phoenix clients can't communicate with older Phoenix servers"
> It should probably error out with "Major version of client is less than that
> of the server"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
