[ 
https://issues.apache.org/jira/browse/PHOENIX-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026364#comment-17026364
 ] 

Hadoop QA commented on PHOENIX-5607:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12992169/PHOENIX-5607.4.x-HBase-1.3.v1.patch
  against 4.x-HBase-1.3 branch at commit 
98452e1ebbc009d5de3ca2acd9701eb99dccf016.
  ATTACHMENT ID: 12992169

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 8 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +    
@Parameters(name="BackwardCompatibilityIT_compatibleClientVersion={0}") // name 
is used by failsafe as file name in reports
+       // For the first code cut of any major version, there wouldn't be any 
backward compatible clients
+       // Hence the test wouldn't run and just return true when the client 
version to be tested is same as current version
+       // For the first code cut of any major version, there wouldn't be any 
backward compatible clients
+       // Hence the test wouldn't run and just return true when the client 
version to be tested is same as current version
+       // For the first code cut of any major version, there wouldn't be any 
backward compatible clients
+       // Hence the test wouldn't run and just return true when the client 
version to be tested is same as current version
+       // For the first code cut of any major version, there wouldn't be any 
backward compatible clients
+       // Hence the test wouldn't run and just return true when the client 
version to be tested is same as current version
+       // For the first code cut of any major version, there wouldn't be any 
backward compatible clients

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.BackwardCompatibilityIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterTableIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3358//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3358//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3358//console

This message is automatically generated.

> Client-server backward compatibility tests 
> -------------------------------------------
>
>                 Key: PHOENIX-5607
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5607
>             Project: Phoenix
>          Issue Type: Test
>    Affects Versions: 4.15.0
>            Reporter: Lars Hofhansl
>            Assignee: Sandeep Guggilam
>            Priority: Blocker
>              Labels: phoenix-hardening
>             Fix For: 4.16.0
>
>         Attachments: PHOENIX-5607.4.x-HBase-1.3.v1.patch
>
>
> Filing this as a blocker for 4.16.0.
> As we've seen with the various failed attempts to release 4.15.0 Phoenix' 
> backwards compatibility story is weak, and lacks tests - in fact there're no 
> tests.
> We should not allow to ship 4.16.0 without improving that and without tests.
> [~ckulkarni], [~gjacoby] , FYI, what we discussed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to