[
https://issues.apache.org/jira/browse/PHOENIX-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027917#comment-17027917
]
Hadoop QA commented on PHOENIX-5607:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12992373/PHOENIX-5607.4.x-HBase-1.3.v2.patch
against 4.x-HBase-1.3 branch at commit
42bb52b4878d8d782a26605c854a4c9f0177e249.
ATTACHMENT ID: 12992373
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+CREATE TABLE my_schema.my_table_delete (id VARCHAR not null primary key,
name VARCHAR) SALT_BUCKETS=4;
+CREATE TABLE IF NOT EXISTS my_schema.my_table (id VARCHAR NOT NULL PRIMARY
KEY, name VARCHAR) VERSIONS=1;
+CREATE VIEW IF NOT EXISTS my_table_view (entity_id VARCHAR) AS SELECT * FROM
my_schema.my_table WHERE name='a_name';
+CREATE TABLE IF NOT EXISTS my_schema.my_table_immutable (id VARCHAR NOT NULL
PRIMARY KEY, name VARCHAR) IMMUTABLE_ROWS=true;
+CREATE TABLE my_schema.my_table_delete (id VARCHAR not null primary key, name
VARCHAR) SALT_BUCKETS=4;
+mvn dependency:copy
-Dartifact=org.apache.phoenix:phoenix-client:$client_version
-DoutputDirectory=$tmp_dir
+java -cp ".:$phoenix_client_jar" sqlline.SqlLine -d
org.apache.phoenix.jdbc.PhoenixDriver -u jdbc:phoenix:$zk_url -n none -p none
--color=false --fastConnect=true --outputformat=csv --silent=true
--verbose=false --isolation=TRANSACTION_READ_COMMITTED --run=$sqlfile &>
$resultfile
+ public static final List<String> COMPATIBLE_CLIENT_VERSIONS =
Arrays.asList("4.14.3-HBase-1.3", "4.15.0-HBase-1.3");
+ int port = getInt(HConstants.ZOOKEEPER_CLIENT_PORT,
HConstants.DEFAULT_ZOOKEPER_CLIENT_PORT, props, conf);
+ final String server = getString(HConstants.ZOOKEEPER_QUORUM,
HConstants.LOCALHOST, props, conf);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.coprocessor.StatisticsCollectionRunTrackerIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3368//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3368//console
This message is automatically generated.
> Client-server backward compatibility tests
> -------------------------------------------
>
> Key: PHOENIX-5607
> URL: https://issues.apache.org/jira/browse/PHOENIX-5607
> Project: Phoenix
> Issue Type: Test
> Affects Versions: 4.15.0
> Reporter: Lars Hofhansl
> Assignee: Sandeep Guggilam
> Priority: Blocker
> Labels: phoenix-hardening
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5607.4.x-HBase-1.3.v1.patch,
> PHOENIX-5607.4.x-HBase-1.3.v2.patch, PHOENIX-5607.4.x-HBase-1.3.v2.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Filing this as a blocker for 4.16.0.
> As we've seen with the various failed attempts to release 4.15.0 Phoenix'
> backwards compatibility story is weak, and lacks tests - in fact there're no
> tests.
> We should not allow to ship 4.16.0 without improving that and without tests.
> [~ckulkarni], [~gjacoby] , FYI, what we discussed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
