yanxinyi commented on a change in pull request #708: PHOENIX-5698 Phoenix Query
with RVC IN list expression generates wron…
URL: https://github.com/apache/phoenix/pull/708#discussion_r384696212
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/expression/ComparisonExpression.java
##########
@@ -367,6 +368,13 @@ public void write(DataOutput output) throws IOException {
@Override
public final <T> T accept(ExpressionVisitor<T> visitor) {
+// if (visitor instanceof WhereOptimizer.KeyExpressionVisitor) {
Review comment:
Actually, this is not a dead comment. I just found that we need to have this
additional check for the RVC comparison
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
