ChinmaySKulkarni commented on a change in pull request #708: PHOENIX-5698
Phoenix Query with RVC IN list expression generates wron…
URL: https://github.com/apache/phoenix/pull/708#discussion_r385357036
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java
##########
@@ -1814,7 +1853,7 @@ public boolean isPartialExtraction() {
public static class SingleKeySlot implements KeySlots {
private final List<KeySlot> slots;
- SingleKeySlot(KeyPart part, int pkPosition, List<KeyRange> ranges)
{
+ public SingleKeySlot(KeyPart part, int pkPosition, List<KeyRange>
ranges) {
Review comment:
Why are all these made public now? Do we need them in tests only? If yes,
can we use `VisibleForTesting` annotations accordingly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
