ChinmaySKulkarni commented on a change in pull request #708: PHOENIX-5698 
Phoenix Query with RVC IN list expression generates wron…
URL: https://github.com/apache/phoenix/pull/708#discussion_r385356617
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java
 ##########
 @@ -661,6 +686,17 @@ private KeySlots newCoerceKeyPart(KeySlot slot, final 
CoerceExpression node) {
                     childPart, ptr, node, extractNodes), slot.getPKPosition(), 
slot.getKeyRanges());
         }
 
+        public boolean isOrderMatter() {
+            return this.orderMatter;
+        }
+
+        public void setOrderMatterToTrue() {
+            this.orderMatter = true;
+        }
+
+        public void setOrderMatterToFalse() {
 
 Review comment:
   Can't we just use 1 setter i.e. `public void setOrderMatters(boolean 
trueOrFalse)`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to