ChinmaySKulkarni commented on a change in pull request #708: PHOENIX-5698
Phoenix Query with RVC IN list expression generates wron…
URL: https://github.com/apache/phoenix/pull/708#discussion_r385359980
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/expression/InListExpressionTest.java
##########
@@ -62,4 +68,83 @@ public void testHashCode() throws Exception {
+ hashCode, firstHashCode, hashCode);
}
}
+
+ @Test
+ public void testKeyPartsForOrderMatters() {
+ List<Expression> expressionList = new ArrayList<>();
+ final RowKeyColumnExpression rowKeyColumnExpressionMock0 =
Mockito.mock(RowKeyColumnExpression.class);
+ when(rowKeyColumnExpressionMock0.getPosition()).thenReturn(0);
+
when(rowKeyColumnExpressionMock0.getDeterminism()).thenReturn(Determinism.ALWAYS);
+
+ final RowKeyColumnExpression rowKeyColumnExpressionMock1 =
Mockito.mock(RowKeyColumnExpression.class);
+ when(rowKeyColumnExpressionMock1.getPosition()).thenReturn(1);
+
when(rowKeyColumnExpressionMock1.getDeterminism()).thenReturn(Determinism.ALWAYS);
+ expressionList.add(rowKeyColumnExpressionMock1);
+ expressionList.add(rowKeyColumnExpressionMock0);
+ RowValueConstructorExpression rvc = new
RowValueConstructorExpression(expressionList, false);
+
+ final PColumn pColumn0 = Mockito.mock(PColumn.class);
+ final PColumn pColumn1 = Mockito.mock(PColumn.class);
+ List<PColumn> pColumnList = new ArrayList<PColumn>(){{add(pColumn1);
add(pColumn0);}};
+ PTable pTable = Mockito.mock(PTable.class);
+ when(pTable.getPKColumns()).thenReturn(pColumnList);
+
+ final WhereOptimizer.KeyExpressionVisitor.BaseKeyPart baseKeyPart0 =
+ new WhereOptimizer.KeyExpressionVisitor.BaseKeyPart(pTable,
null, new ArrayList<Expression>(){{add(rowKeyColumnExpressionMock0);}});
+ final WhereOptimizer.KeyExpressionVisitor.BaseKeyPart baseKeyPart1 =
+ new WhereOptimizer.KeyExpressionVisitor.BaseKeyPart(pTable,
null, new ArrayList<Expression>(){{add(rowKeyColumnExpressionMock1);}});
+ List<WhereOptimizer.KeyExpressionVisitor.KeySlots> children =
+ new ArrayList<WhereOptimizer.KeyExpressionVisitor.KeySlots>()
{{
+ add(new
WhereOptimizer.KeyExpressionVisitor.SingleKeySlot(baseKeyPart1,1, null));
+ add(new
WhereOptimizer.KeyExpressionVisitor.SingleKeySlot(baseKeyPart0,0, null));
+ }};
+
+ WhereOptimizer.KeyExpressionVisitor visitor = new
WhereOptimizer.KeyExpressionVisitor(null, pTable);
+ visitor.setOrderMatterToTrue();
+ WhereOptimizer.KeyExpressionVisitor.KeySlots resultKeySlots =
visitor.newRowValueConstructorKeyParts(rvc, children);
+ WhereOptimizer.KeyExpressionVisitor.RowValueConstructorKeyPart keyPart
=
+
(WhereOptimizer.KeyExpressionVisitor.RowValueConstructorKeyPart)
+
resultKeySlots.getSlots().iterator().next().getKeyPart();
+ assertEquals(1,
keyPart.getChildSlots().get(0).getSlots().get(0).getPKPosition());
+ }
+
+ @Test
+ public void testKeyPartsForOrderDoesNotMatter() {
+ List<Expression> expressionList = new ArrayList<>();
+ final RowKeyColumnExpression rowKeyColumnExpressionMock0 =
Mockito.mock(RowKeyColumnExpression.class);
+ when(rowKeyColumnExpressionMock0.getPosition()).thenReturn(0);
+
when(rowKeyColumnExpressionMock0.getDeterminism()).thenReturn(Determinism.ALWAYS);
+
+ final RowKeyColumnExpression rowKeyColumnExpressionMock1 =
Mockito.mock(RowKeyColumnExpression.class);
+ when(rowKeyColumnExpressionMock1.getPosition()).thenReturn(1);
+
when(rowKeyColumnExpressionMock1.getDeterminism()).thenReturn(Determinism.ALWAYS);
Review comment:
Ideally you should move all this into a `setup` BeforeClass/Before method
since it's not really part of the test. Only the steps that are different for
each unit test should be contained here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
