yanxinyi commented on a change in pull request #708: PHOENIX-5698 Phoenix Query 
with RVC IN list expression generates wron…
URL: https://github.com/apache/phoenix/pull/708#discussion_r385506276
 
 

 ##########
 File path: 
phoenix-core/src/test/java/org/apache/phoenix/expression/InListExpressionTest.java
 ##########
 @@ -62,4 +68,83 @@ public void testHashCode() throws Exception {
                     + hashCode, firstHashCode, hashCode);
         }
     }
+
+    @Test
+    public void testKeyPartsForOrderMatters() {
 
 Review comment:
   @dbwong this is only testing one thing here, which is whether we have pk 
ordering or not.
   Due to the way how Phoenix implemented, it's very hard to do the unit tests.
   
   @ChinmaySKulkarni sure will do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to