yanxinyi commented on a change in pull request #708: PHOENIX-5698 Phoenix Query
with RVC IN list expression generates wron…
URL: https://github.com/apache/phoenix/pull/708#discussion_r385496567
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/InListIT.java
##########
@@ -537,4 +539,267 @@ public void testInListExpressionWithDesc() throws
Exception {
}
}
+ @Test
+ public void testInListExpressionWithDescOrderWithRightQueryPlan() throws
Exception {
+ String fullTableName = generateUniqueName();
+ String fullViewName = generateUniqueName();
+ String tenantView = generateUniqueName();
+
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+ conn.setAutoCommit(true);
+ Statement stmt = conn.createStatement();
+ stmt.execute("CREATE TABLE " + fullTableName + "(\n" + " TENANT_ID
CHAR(15) NOT NULL,\n" + " KEY_PREFIX CHAR(3) NOT NULL,\n" +
+ " CONSTRAINT PK PRIMARY KEY (\n" + " TENANT_ID," + "
KEY_PREFIX" + ")) MULTI_TENANT=TRUE");
+ stmt.execute("CREATE VIEW " + fullViewName + "(\n" + " ID1 VARCHAR
NOT NULL,\n" + " ID2 VARCHAR NOT NULL,\n" + " EVENT_DATE DATE NOT NULL,\n" +
+ " CONSTRAINT PKVIEW PRIMARY KEY\n" + " (\n" + " ID1, ID2
DESC, EVENT_DATE DESC\n" + ")) " +
+ "AS SELECT * FROM " + fullTableName + " WHERE KEY_PREFIX =
'0CY'");
+ }
+
+
+ try (Connection viewConn =
DriverManager.getConnection(TENANT_SPECIFIC_URL1)) {
+ viewConn.setAutoCommit(true);
+ Statement stmt = viewConn.createStatement();
+ stmt.execute("CREATE VIEW IF NOT EXISTS " + tenantView + " AS
SELECT * FROM " + fullViewName);
+ viewConn.createStatement().execute("UPSERT INTO " + tenantView +
"(ID1, ID2, EVENT_DATE) VALUES " +
+ "('005xx000001Sv6o', '000000000000300', 1532458230000)");
+ viewConn.createStatement().execute("UPSERT INTO " + tenantView +
"(ID1, ID2, EVENT_DATE) VALUES " +
+ "('005xx000001Sv6o', '000000000000400', 1532458240000)");
+ viewConn.createStatement().execute("UPSERT INTO " + tenantView +
"(ID1, ID2, EVENT_DATE) VALUES " +
+ "('005xx000001Sv6o', '000000000000500', 1532458250000)");
+ viewConn.commit();
+
+ ResultSet rs = stmt.executeQuery("EXPLAIN DELETE FROM " +
tenantView + " WHERE (ID1, ID2, EVENT_DATE) " +
+ "IN (('005xx000001Sv6o', '000000000000400',
1532458240000)," +
+ "('005xx000001Sv6o', '000000000000300', 1532458230000))");
+ assertTrue(getExplainPlanString(rs).contains("CLIENT PARALLEL
1-WAY RANGE SCAN"));
+
+ rs = stmt.executeQuery("EXPLAIN DELETE FROM " + tenantView + "
WHERE (ID1, EVENT_DATE, ID2) IN " +
+ "(('005xx000001Sv6o', 1532458240000, '000000000000400')," +
+ "('005xx000001Sv6o', 1532458230000, '000000000000300'))");
+ assertTrue(getExplainPlanString(rs).contains("CLIENT PARALLEL
1-WAY RANGE SCAN"));
+
+ rs = stmt.executeQuery("EXPLAIN DELETE FROM " + tenantView + "
WHERE (ID2, EVENT_DATE, ID1) IN " +
+ "(('000000000000400', 1532458240000, '005xx000001Sv6o')," +
+ "('000000000000300', 1532458230000, '005xx000001Sv6o'))");
+ assertTrue(getExplainPlanString(rs).contains("CLIENT PARALLEL
1-WAY RANGE SCAN"));
+
+ rs = stmt.executeQuery("EXPLAIN DELETE FROM " + tenantView + "
WHERE (EVENT_DATE, ID2, ID1) IN " +
+ "((1532458240000, '000000000000400', '005xx000001Sv6o')," +
+ "(1532458230000, '000000000000300', '005xx000001Sv6o'))");
+ assertTrue(getExplainPlanString(rs).contains("CLIENT PARALLEL
1-WAY RANGE SCAN"));
+
+ stmt.execute("DELETE FROM " + tenantView + " WHERE (EVENT_DATE,
ID2, ID1) IN " +
+ "((1532458240000, '000000000000400', '005xx000001Sv6o')," +
+ "(1532458230000, '000000000000300', '005xx000001Sv6o'))");
+
+ rs = stmt.executeQuery("SELECT ID2 FROM " + tenantView);
+ assertTrue(rs.next());
+ assertEquals("000000000000500", rs.getString(1));
+ }
+ }
+
+ @Test
+ public void testInListExpressionWithRightQueryPlan() throws Exception {
+ String fullTableName = generateUniqueName();
+ String fullViewName = generateUniqueName();
+ String tenantView = generateUniqueName();
+
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+ conn.setAutoCommit(true);
+ Statement stmt = conn.createStatement();
+ stmt.execute("CREATE TABLE " + fullTableName + "(\n" + " TENANT_ID
CHAR(15) NOT NULL,\n" + " KEY_PREFIX CHAR(3) NOT NULL,\n" +
+ " CONSTRAINT PK PRIMARY KEY (\n" + " TENANT_ID," + "
KEY_PREFIX" + ")) MULTI_TENANT=TRUE");
+ stmt.execute("CREATE VIEW " + fullViewName + "(\n" + " ID1 VARCHAR
NOT NULL,\n" + " ID2 VARCHAR NOT NULL,\n" + " EVENT_DATE DATE, ID3 BIGINT NOT
NULL \n" +
+ " CONSTRAINT PKVIEW PRIMARY KEY\n" + " (ID1, ID2, ID3)) " +
+ "AS SELECT * FROM " + fullTableName + " WHERE KEY_PREFIX =
'0CY'");
+ }
+
+ try (Connection viewConn =
DriverManager.getConnection(TENANT_SPECIFIC_URL1)) {
+ viewConn.setAutoCommit(true);
+ Statement stmt = viewConn.createStatement();
+ stmt.execute("CREATE VIEW IF NOT EXISTS " + tenantView + " AS
SELECT * FROM " + fullViewName);
+
+ viewConn.createStatement().execute("UPSERT INTO " + tenantView +
"(ID1, ID2, ID3) VALUES " +
+ "('005xx000001Sv6o', '000000000000300', 1)");
+ viewConn.createStatement().execute("UPSERT INTO " + tenantView +
"(ID1, ID2, ID3) VALUES " +
+ "('005xx000001Sv6o', '000000000000400', 3)");
+ viewConn.commit();
+
+ ResultSet rs = stmt.executeQuery("EXPLAIN DELETE FROM " +
tenantView + " WHERE (ID1, ID2, ID3) IN " +
+ "(('005xx000001Sv6o', '000000000000500',1)," +
+ "('005xx000001Sv6o', '000000000000400',2)," +
+ "('005xx000001Sv6o', '000000000000300',3))");
+
+ assertTrue(getExplainPlanString(rs).contains("DELETE SINGLE ROW"));
+
+ rs = stmt.executeQuery("EXPLAIN DELETE FROM " + tenantView + "
WHERE (ID2, ID1, ID3) IN " +
+ "(('000000000000400', '005xx000001Sv6o', 1)," +
+ "('000000000000300', '005xx000001Sv6o', 2))");
+ assertTrue(getExplainPlanString(rs).contains("DELETE SINGLE ROW"));
+
+ stmt.execute("DELETE FROM " + tenantView + " WHERE (ID3, ID2, ID1)
IN " +
+ "((1, '000000000000300', '005xx000001Sv6o'))");
+
+ rs = stmt.executeQuery("SELECT ID2 FROM " + tenantView);
+ assertTrue(rs.next());
+ assertEquals("000000000000400", rs.getString(1));
+ }
+ }
+
+ private String getExplainPlanString(ResultSet rs) throws SQLException {
+ StringBuilder builder = new StringBuilder();
+ while (rs.next()) {
+ for (int i = 0; i < rs.getMetaData().getColumnCount(); i++) {
+ Object col = rs.getObject(i + 1);
+ if (col != null) {
+ builder.append(col.toString());
+ builder.append(",");
+ }
+ }
+ builder.append("\n");
+ }
+ return builder.toString();
+ }
+
+ @Test
+ public void testInListExpressionGeneratesRightScan() throws Exception {
+ String fullTableName = generateUniqueName();
+ String fullViewName = generateUniqueName();
+ String tenantView = generateUniqueName();
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+ conn.setAutoCommit(true); Statement stmt = conn.createStatement();
+ stmt.execute("CREATE TABLE " + fullTableName + "(\n" + " TENANT_ID
CHAR(15) NOT NULL,\n" + " KEY_PREFIX CHAR(3) NOT NULL,\n" +
+ " CONSTRAINT PK PRIMARY KEY (\n" + " TENANT_ID," + "
KEY_PREFIX" + ")) MULTI_TENANT=TRUE");
+ stmt.execute("CREATE VIEW " + fullViewName + "(\n" + " ID1 VARCHAR
NOT NULL,\n" + " ID2 VARCHAR NOT NULL,\n" + " ID3 BIGINT, ID4 BIGINT \n" +
+ " CONSTRAINT PKVIEW PRIMARY KEY\n" + " (ID1, ID2)) " +
+ "AS SELECT * FROM " + fullTableName + " WHERE KEY_PREFIX =
'0CY'");
+ }
+ try (Connection viewConn =
DriverManager.getConnection(TENANT_SPECIFIC_URL1) ) {
+ viewConn.setAutoCommit(true);
+ Statement stmt = viewConn.createStatement();
+ stmt.execute("CREATE VIEW IF NOT EXISTS " + tenantView + " AS
SELECT * FROM " + fullViewName);
+ }
+ testFullPkListPlan(tenantView);
+ testFullPkPlusNonPkInListPlan(tenantView);
+ testPartialPkListPlan(tenantView);
+ testPartialPkPlusNonPkListPlan(tenantView);
+ testNonPkListPlan(tenantView);
+ }
+
+ private void testFullPkPlusNonPkInListPlan(String tenantView) throws
Exception {
+ Long numberOfRowsToScan = new Long(2);
+ try (Connection viewConn =
DriverManager.getConnection(TENANT_SPECIFIC_URL1) ) {
+ PreparedStatement preparedStmt = viewConn.prepareStatement("SELECT
* FROM " + tenantView + " WHERE (ID1, ID2, ID3) IN " +
+ "(('005xx000001Sv6o', '000000000000500', 1)," +
+ "('005xx000001Sv6o', '000000000000400', 2))");
+ QueryPlan queryPlan =
PhoenixRuntime.getOptimizedQueryPlan(preparedStmt);
+ assertEquals(numberOfRowsToScan,
queryPlan.getEstimatedRowsToScan());
+
assertTrue(queryPlan.getExplainPlan().toString().contains(ExplainTable.POINT_LOOKUP_ON_STRING));
Review comment:
other strings are not easy to abstract due to the way how to generates the
diff query plan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
