[
https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060135#comment-17060135
]
Istvan Toth commented on PHOENIX-5778:
--------------------------------------
I do not dispute that we are using classes in the tests that are not marked
Public.
But these are in the tests, and not in the actual libraries, so even if they
change, they have no effect on the users of PQS or the client, only on the
developers.
If we were to go down this path, then we should logically replace all
HBase/Hadoop classes that are not marked as Public/Limited, and there are quite
a few of those even in these few tests.
I am not even sure if it is possible to run these tests without referring to
private classes, and if it is, I do not think that anyone wants to spend the
effort to make sure that we only use Public interfaces.
If any of those go away or change in the future, we can fix them as we go.
> Remove the dependency of KeyStoreTestUtil
> -----------------------------------------
>
> Key: PHOENIX-5778
> URL: https://issues.apache.org/jira/browse/PHOENIX-5778
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Guanghao Zhang
> Priority: Major
> Fix For: 5.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If I am not wrong, phoenix should reduce the dependency of hbase
> class/interface which not marked IA.Public. KeyStoreTestUtil is just a
> static util class. I thought phoenix query server can copy a new one and not
> depend on hbase's KeyStoreTestUtil.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
