[
https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060508#comment-17060508
]
Guanghao Zhang commented on PHOENIX-5778:
-----------------------------------------
bq. It is a calculated risk vs copying the class
Yes. Dependency hbase has risk. But what is the risk of copying the class?
bq. But we also use it to initialize the HDFS cluster, and where we need to set
the hadoop properties. If there was a hadoop class with similar functionality,
we'd use that, but there isn't, so the HBase class is the next best thing.
We use KeyStoreTestUtil.setupSSLConfig to set four hadoop properties, not hbase
properties. Why let hbase to help do this not queryserverl itself? If other
project has similar functionality, can we dependency it?
> Remove the dependency of KeyStoreTestUtil
> -----------------------------------------
>
> Key: PHOENIX-5778
> URL: https://issues.apache.org/jira/browse/PHOENIX-5778
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: queryserver-1.0.0
> Reporter: Guanghao Zhang
> Priority: Major
> Fix For: queryserver-1.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If I am not wrong, phoenix should reduce the dependency of hbase
> class/interface which not marked IA.Public. KeyStoreTestUtil is just a
> static util class. I thought phoenix query server can copy a new one and not
> depend on hbase's KeyStoreTestUtil.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
