[ 
https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060225#comment-17060225
 ] 

Guanghao Zhang commented on PHOENIX-5778:
-----------------------------------------

Sir. I got your point. “Add different profiles” may be a good method for other 
cases. But for this class KeyStoreTestUtil, it is not realted to hbase too 
much. Add a new hbase-http dependency for a util test class. I thought this is 
not necessary :(

> Remove the dependency of KeyStoreTestUtil
> -----------------------------------------
>
>                 Key: PHOENIX-5778
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5778
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Guanghao Zhang
>            Priority: Major
>             Fix For: 5.1.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> If I am not wrong, phoenix should reduce the dependency of hbase 
> class/interface which not marked IA.Public.  KeyStoreTestUtil is just a 
> static util class. I thought phoenix query server can copy a new one and not 
> depend on hbase's KeyStoreTestUtil.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to