[
https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060205#comment-17060205
]
Istvan Toth commented on PHOENIX-5778:
--------------------------------------
That's a different situation.
I've tried to run your branch with *mvn clean verify -Dhbase.version=2.2.1
-Dhadoop-two.version=3.0.1 -Dphoenix.version=5.1.0-SNAPSHOT* , and I got a
compilation failure because of a missing bouncycastle dependency.
However, I don't think that copying that class is the right solution,
especially considering that the bouncycastle dependency also seems to be
required with HBase 2, and I am not sure that hadoop2 and hadoop3 work well
with the sam bouncycastle dependency version.
We can do one of three things:
* Do nothing, and keep testing only against 4.x
* Update repo and dependencies to test against master
* Add profiles to be able to test against both 4.x and master
Keep in mind, that the return for testing with different Phoenix versions is
rather limited, as we are mostly testing the avatica client and server
functionality, and not Phoenix itself.
To test against master, we need to add something like this to
queryserver/pom.xml:
{code:java}
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-http</artifactId>
<scope>test</scope>
<type>test-jar</type>
</dependency>
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-http</artifactId>
<scope>test</scope>
<type>test-jar</type>
</dependency><dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
<version>1.64</version>
</dependency>
{code}
I think that a better solution would be leaving the java code as is, and adding
a two maven profiles for testing against Phoenix 4.x and 5.x, as properly
handling the bouncycastle situation needs profiles anyway.
You could set the _hbase.version_, _hadoop-two.version_ to the one used on the
phoenix master branch, (actually, hadoop-two.version should be renamed as
well), and add a default for _phoenix-version_ there, as well as adding the
test and test:test-jar dependencies for hbase-http, and bouncycastle, as it
seems to be also required for hbase 2.
Please reply
> Remove the dependency of KeyStoreTestUtil
> -----------------------------------------
>
> Key: PHOENIX-5778
> URL: https://issues.apache.org/jira/browse/PHOENIX-5778
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Guanghao Zhang
> Priority: Major
> Fix For: 5.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If I am not wrong, phoenix should reduce the dependency of hbase
> class/interface which not marked IA.Public. KeyStoreTestUtil is just a
> static util class. I thought phoenix query server can copy a new one and not
> depend on hbase's KeyStoreTestUtil.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
