tkhurana commented on a change in pull request #743: PHOENIX-5798 IndexUpgrade
tool command line improvements
URL: https://github.com/apache/phoenix/pull/743#discussion_r400532714
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
##########
@@ -235,6 +240,11 @@ public CommandLine parseOptions(String[] args) {
+TABLE_OPTION.getLongOpt() + " and " +
TABLE_CSV_FILE_OPTION.getLongOpt()
+ "; specify only one.");
}
+ if ((cmdLine.hasOption(INDEX_TOOL_OPTION.getOpt()))
Review comment:
@priyankporwal Are you suggesting something like this `-rebuild '-v ONLY'` ?
I agree that would simplify some things. The only thing is that a value will
always have to be passed to that option even if you want to run IndexTool with
default options. Options can either always take a value or never take a value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
