tkhurana commented on a change in pull request #743: PHOENIX-5798 IndexUpgrade
tool command line improvements
URL: https://github.com/apache/phoenix/pull/743#discussion_r398812229
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
##########
@@ -577,6 +582,10 @@ private void rebuildIndexes(Connection conn,
Configuration conf, ArrayList<Strin
if (!upgrade) {
return;
}
+ if (!rebuild) {
+ return;
+ }
+
Review comment:
We are already logging the options passed to IndexUpgradeTool
https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java#L186
and IndexTool
https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java#L688
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
