priyankporwal commented on a change in pull request #743: PHOENIX-5798
IndexUpgrade tool command line improvements
URL: https://github.com/apache/phoenix/pull/743#discussion_r399833215
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
##########
@@ -235,6 +240,11 @@ public CommandLine parseOptions(String[] args) {
+TABLE_OPTION.getLongOpt() + " and " +
TABLE_CSV_FILE_OPTION.getLongOpt()
+ "; specify only one.");
}
+ if ((cmdLine.hasOption(INDEX_TOOL_OPTION.getOpt()))
Review comment:
Just a thought, would it be simpler to have just one IndexUpgradeTool option
which when present indicates both do-rebuild as well as give IndexTool options?
We wouldn't need this check then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
