tkhurana commented on code in PR #1880:
URL: https://github.com/apache/phoenix/pull/1880#discussion_r1565842537
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -800,6 +799,8 @@ public List<HRegionLocation> getTableRegions(byte[]
tableName, byte[] startRowKe
&& Bytes.compareTo(currentKey, endRowKey) >= 0) {
break;
}
+ throwErrorIfQueryTimedOut(startRowKey, endRowKey,
maxQueryEndTime,
Review Comment:
I think we can test this by setting a low value for a query timeout and
creating a table with multiple regions either through salting or split points.
PhoenixQueryTimeoutIT seems like a good candidate for this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
