virajjasani commented on code in PR #1880:
URL: https://github.com/apache/phoenix/pull/1880#discussion_r1568487609
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -800,6 +799,8 @@ public List<HRegionLocation> getTableRegions(byte[]
tableName, byte[] startRowKe
&& Bytes.compareTo(currentKey, endRowKey) >= 0) {
break;
}
+ throwErrorIfQueryTimedOut(startRowKey, endRowKey,
maxQueryEndTime,
Review Comment:
One of the tests in PhoenixQueryTimeoutIT is already covering this even
without having to split/salt the table. However, the way
`BaseResultIterators.setForTestingSetTimeoutToMaxToLetQueryPassHere` is being
used is causing issues. We will have to clean it up or separate the test using
it to different class. Given that it is static, it has potential to run into
issues while running any other test in parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
