virajjasani commented on code in PR #1880:
URL: https://github.com/apache/phoenix/pull/1880#discussion_r1569129093
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServices.java:
##########
@@ -99,22 +99,27 @@ public interface ConnectionQueryServices extends
QueryServices, MetaDataMutated
public TableDescriptor getTableDescriptor(byte[] tableName) throws
SQLException;
public HRegionLocation getTableRegionLocation(byte[] tableName, byte[]
row) throws SQLException;
- public List<HRegionLocation> getAllTableRegions(byte[] tableName) throws
SQLException;
+
+ public List<HRegionLocation> getAllTableRegions(byte[] tableName, int
queryTimeout)
Review Comment:
The clients using the API either have StatementContext object or they have
Config object so either way they need to provide timeout anyway.
If we keep the API as is, anyone would only use that directly even though
they might have PhoenixStatement level overridden timeout. So using public API
without timeout is not good practice anyway right?
For ScanningResultIterator, the constructor has timeout param and the
clients are either providing Long.MAX_VALUE or Context level overridden timeout
but the pattern is same i.e. clients using the APIs are providing timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
