tkhurana commented on code in PR #1880:
URL: https://github.com/apache/phoenix/pull/1880#discussion_r1569113972
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServices.java:
##########
@@ -99,22 +99,27 @@ public interface ConnectionQueryServices extends
QueryServices, MetaDataMutated
public TableDescriptor getTableDescriptor(byte[] tableName) throws
SQLException;
public HRegionLocation getTableRegionLocation(byte[] tableName, byte[]
row) throws SQLException;
- public List<HRegionLocation> getAllTableRegions(byte[] tableName) throws
SQLException;
+
+ public List<HRegionLocation> getAllTableRegions(byte[] tableName, int
queryTimeout)
Review Comment:
I would recommend not changing the public API but add a new API. We had
similar problems in the past when we introduced a timeout in
ScanningResultIterator. The existing APIs can send values like LONG.max.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
