shahrs87 commented on code in PR #1859:
URL: https://github.com/apache/phoenix/pull/1859#discussion_r1569445197
##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixTableLevelMetricsIT.java:
##########
@@ -1276,14 +1281,24 @@ public void testMetricsWithIndexUsage() throws
Exception {
assertTrue(metricExists);
metricExists = false;
//assert BaseTable is not being queried
- for (PhoenixTableMetric metric :
getPhoenixTableClientMetrics().get(dataTable)) {
- if (metric.getMetricType().equals(SELECT_SQL_COUNTER)) {
- metricExists = true;
- assertMetricValue(metric, SELECT_SQL_COUNTER, 0,
CompareOp.EQ);
- break;
+ //if client is validating last_ddl_timestamps with ucf=never,
+ //there will be no metrics for base table (like getTable RPC
times/counts).
+ boolean lastDDLTimestampValidationEnabled =
+
conn.unwrap(PhoenixConnection.class).getQueryServices().getProps().getBoolean(
Review Comment:
Do you want to use
[ValidateLastDDLTimestampUtil#getValidateLastDdlTimestampEnabled](https://github.com/apache/phoenix/blob/PHOENIX-6883-feature/phoenix-core-client/src/main/java/org/apache/phoenix/util/ValidateLastDDLTimestampUtil.java#L73C27-L73C61)
method instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
