palashc commented on code in PR #1859:
URL: https://github.com/apache/phoenix/pull/1859#discussion_r1569809009
##########
phoenix-core/src/it/java/org/apache/phoenix/query/MetaDataCachingIT.java:
##########
@@ -152,12 +156,19 @@ public void testGlobalClientCacheMetrics() throws
Exception {
simulateWorkload("testGlobalClientCacheMetrics", numTables,
numThreads, numMaxDML);
// only 1 miss when the table is created
+ int numExpectedMisses = 1;
+ if
(QueryServicesOptions.DEFAULT_LAST_DDL_TIMESTAMP_VALIDATION_ENABLED) {
Review Comment:
@shahrs87 I have made the change in MetaDataClient.java as that is
production code. For the test code, maybe it is not required? Also in some
tests, we do not have a connection object which can be used directly for
`getValidateLastDdlTimestampEnabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
