shahrs87 commented on code in PR #1859:
URL: https://github.com/apache/phoenix/pull/1859#discussion_r1569452771


##########
phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheConnectionLevelPropIT.java:
##########
@@ -61,6 +62,9 @@ public class UpdateCacheConnectionLevelPropIT extends 
ParallelStatsDisabledIT {
     private static Connection conn1;
     private static Connection conn2;
     private static ConnectionQueryServices spyForConn2;
+    private boolean isLastDDLTimestampValidationEnabled

Review Comment:
   Why not to get the last ddl timestamp validation enabled flag from the 
connection properties?



##########
phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheIT.java:
##########
@@ -69,6 +70,10 @@
 @Category(ParallelStatsDisabledTest.class)
 public class UpdateCacheIT extends ParallelStatsDisabledIT {
 
+    private boolean isLastDDLTimestampValidationEnabled
+            = 
QueryServicesOptions.DEFAULT_LAST_DDL_TIMESTAMP_VALIDATION_ENABLED

Review Comment:
   Why not to get the last ddl timestamp validation enabled flag from the 
connection properties?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to