shahrs87 commented on code in PR #1859:
URL: https://github.com/apache/phoenix/pull/1859#discussion_r1571130674
##########
phoenix-core-client/src/main/java/org/apache/phoenix/compile/FromCompiler.java:
##########
@@ -297,7 +297,9 @@ public static ColumnResolver
getIndexResolver(SingleTableStatement statement,
public static ColumnResolver getResolver(SingleTableStatement statement,
PhoenixConnection connection, Map<String, UDFParseNode> udfParseNodes)
throws SQLException {
- SingleTableColumnResolver visitor = new
SingleTableColumnResolver(connection, statement.getTable(), true, 0,
udfParseNodes);
+ SingleTableColumnResolver visitor
Review Comment:
I see that we are calling this resolver from `MetaDataClient#createIndex
`and `CreateIndexCompiler#compile` method. So we want to bypass cache for
createIndex and resolve table always. So lets rename this method to
`getResolverForCreateIndex` and add a comment on why we are setting
`alwaysHitServer` to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
