d-c-manning commented on code in PR #2061:
URL: https://github.com/apache/phoenix/pull/2061#discussion_r1932743314
##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java:
##########
@@ -487,7 +495,7 @@ public void testMetricsForUpsert() throws Exception {
String t = entry.getKey();
assertEquals("Table names didn't match!", tableName, t);
Map<MetricType, Long> p = entry.getValue();
- assertEquals("There should have been sixteen metrics", 16,
p.size());
+ assertEquals("There should have been sixteen metrics", 22,
p.size());
Review Comment:
either remove the text, or update the text
```suggestion
assertEquals("There should have been 22 metrics", 22, p.size());
```
##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java:
##########
@@ -157,7 +157,7 @@ public void testPhoenixMetricsLoggedOnClose() throws
Exception {
// Hence mutation metrics are not expected during connection close
loggedConn.close();
assertTrue("Mutation write metrics are not logged for " + tableName2,
- mutationWriteMetricsMap.size() == 0);
+ mutationWriteMetricsMap.size() > 0);
Review Comment:
the text for `assertTrue`, and the comment above, should be updated to
reflect the new reality.
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java:
##########
@@ -1660,4 +1660,12 @@ public static long getCurrentScn(ReadOnlyProps props) {
String scn = props.get(CURRENT_SCN_ATTRIB);
return scn != null ? Long.parseLong(scn) : HConstants.LATEST_TIMESTAMP;
}
+
+ public static long convertTimeInNsToMs(long value) {
Review Comment:
these duplicate `EnvironmentEdge#convertNsToMs` - can we share?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
