d-c-manning commented on code in PR #2061:
URL: https://github.com/apache/phoenix/pull/2061#discussion_r1934264080
##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java:
##########
@@ -156,9 +156,9 @@ public void testPhoenixMetricsLoggedOnClose() throws
Exception {
// Autocommit is turned off by default
// Hence mutation metrics are not expected during connection close
Review Comment:
I don't fully understand the scenario and the impact. The test makes me
think that before, without a call to `commit` or `setAutoCommit(true)`, then an
`executeUpdate` is insufficient to make any writes, and therefore you have no
mutation metrics. But now, even without a `commit`, we have some write metrics.
But what are those metrics? Is it just the time taken for the mutation
planning? Should the test confirm that those are the only metrics present?
Otherwise no, it does not seem to be an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
