sanjeet006py commented on code in PR #2061:
URL: https://github.com/apache/phoenix/pull/2061#discussion_r1933345150
##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java:
##########
@@ -156,9 +156,9 @@ public void testPhoenixMetricsLoggedOnClose() throws
Exception {
// Autocommit is turned off by default
// Hence mutation metrics are not expected during connection close
Review Comment:
Thanks. Yes, now when `auto-commit` is off then we do expect mutation
metrics to be there on connection close() as we are now recording metrics for
`executeUpdate()` call also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
