sanjeet006py commented on code in PR #2061:
URL: https://github.com/apache/phoenix/pull/2061#discussion_r1934288072
##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java:
##########
@@ -156,9 +156,9 @@ public void testPhoenixMetricsLoggedOnClose() throws
Exception {
// Autocommit is turned off by default
// Hence mutation metrics are not expected during connection close
Review Comment:
> I don't fully understand the scenario and the impact.
The test seems to be asserting the metrics are being populated on calling
`Connection.close()` only when they should be populated and is testing two
cases: for reads and for writes. Before my change, no metrics were expected for
writes on calling `Connection.close()` when `commit()` has not been called
(explicitly/implicitly). But now we do expect metrics to be populated for
writes even if `commit()` is not called and these metrics are for time taken in
mutation plan creation and execution. So, time taken by mutation planning (plan
creation + execution) is also being populated in MutationMetrics and will be
available even if `commit()` is not called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
