eric-maynard commented on code in PR #404:
URL: https://github.com/apache/polaris/pull/404#discussion_r1821660397
##########
regtests/client/python/cli/command/catalog_roles.py:
##########
@@ -46,6 +46,8 @@ class CatalogRolesCommand(Command):
catalog_role_name: str
principal_role_name: str
properties: Optional[Dict[str, StrictStr]]
Review Comment:
That makes sense. My initial hesitation was just having two properties that
do the same thing.
Lets keep this, but I think we should reject the "invalid" inputs then:
`catalogs update some_catalog --property k=v`
`catalogs update some_catalog --set-property k=v`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
