sfc-gh-dhuo commented on code in PR #404:
URL: https://github.com/apache/polaris/pull/404#discussion_r1821530070
##########
regtests/client/python/cli/command/catalog_roles.py:
##########
@@ -46,6 +46,8 @@ class CatalogRolesCommand(Command):
catalog_role_name: str
principal_role_name: str
properties: Optional[Dict[str, StrictStr]]
Review Comment:
My thinking for preserving `--property` for `create` is to emphasize the
contrasting "declarative" semantics of CREATE vs the choice of having an
"imperative" semantic for UPDATE. Looking at examples of other CLIs with a
similar split, the same pattern is used:
gcloud compute instances create ... --labels=...
gcloud compute instances update ... --update-labels=...
--remove-labels=...
And similarly `--update-labels` and `--remove-labels` aren't available in
the `create` command, while `--labels` is not available in the `update` command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
