sfc-gh-dhuo commented on code in PR #404:
URL: https://github.com/apache/polaris/pull/404#discussion_r1821815631
##########
regtests/client/python/cli/command/catalog_roles.py:
##########
@@ -46,6 +46,8 @@ class CatalogRolesCommand(Command):
catalog_role_name: str
principal_role_name: str
properties: Optional[Dict[str, StrictStr]]
Review Comment:
Agreed, this test case in test_cli_parsing.py covers the rejection of
`--property`:
https://github.com/apache/polaris/pull/404/files#diff-437c53a66ce1039f3ff70bef07bb0325924edf2b8f2c864762969e6ecdde3ecfR58
with self.assertRaises(SystemExit) as cm:
Parser.parse(['catalogs', 'update', 'catalog_name',
'--property', 'foo=bar'])
self.assertEqual(cm.exception.code, INVALID_ARGS)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
