dennishuo commented on code in PR #404:
URL: https://github.com/apache/polaris/pull/404#discussion_r1821537605


##########
regtests/client/python/cli/options/option_tree.py:
##########
@@ -157,7 +160,8 @@ def get_tree() -> List[Option]:
                 ], input_name=Arguments.CATALOG),
                 Option(Subcommands.UPDATE, args=[
                     Argument(Arguments.CATALOG, str, 
Hints.CatalogRoles.CATALOG_NAME),
-                    Argument(Arguments.PROPERTY, str, Hints.PROPERTY, 
allow_repeats=True)
+                    Argument(Arguments.SET_PROPERTY, str, Hints.SET_PROPERTY, 
allow_repeats=True),
+                    Argument(Arguments.REMOVE_PROPERTY, str, 
Hints.REMOVE_PROPERTY, allow_repeats=True),
                 ], input_name=Arguments.CATALOG_ROLE),
                 Option(Subcommands.GRANT, 
hint=Hints.CatalogRoles.GRANT_CATALOG_ROLE, args=[
                     Argument(Arguments.CATALOG, str, 
Hints.CatalogRoles.CATALOG_NAME),

Review Comment:
   Right, for now namespaces don't actually have an `update` command yet (and 
never had one) so we can fill in missing features for namespaces in a separate 
PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to