omarsmak commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1988516970
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -250,6 +268,21 @@ public Builder setStorageConfigurationInfo(
awsConfig.validateArn(awsConfigModel.getRoleArn());
config = awsConfig;
break;
+
+ case S3_COMPATIBLE:
+ S3CompatibleStorageConfigInfo s3ConfigModel =
+ (S3CompatibleStorageConfigInfo) storageConfigModel;
+ config =
+ new S3CompatibleStorageConfigurationInfo(
Review Comment:
Don't we as well need pass a custom STS endpoint in order to initialize
STSClient with a custom endpoint that points to MinIO as an example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
