gh-yzou commented on code in PR #1147: URL: https://github.com/apache/polaris/pull/1147#discussion_r1996571245
########## service/common/src/main/java/org/apache/polaris/service/catalog/generic/PolarisGenericTableCatalog.java: ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.catalog.generic; + +import jakarta.ws.rs.core.SecurityContext; +import java.util.List; +import java.util.Map; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.exceptions.AlreadyExistsException; +import org.apache.iceberg.exceptions.NoSuchTableException; +import org.apache.polaris.core.context.CallContext; +import org.apache.polaris.core.entity.CatalogEntity; +import org.apache.polaris.core.entity.GenericTableEntity; +import org.apache.polaris.core.entity.PolarisEntity; +import org.apache.polaris.core.entity.PolarisEntitySubType; +import org.apache.polaris.core.entity.PolarisEntityType; +import org.apache.polaris.core.persistence.PolarisEntityManager; +import org.apache.polaris.core.persistence.PolarisMetaStoreManager; +import org.apache.polaris.core.persistence.PolarisResolvedPathWrapper; +import org.apache.polaris.core.persistence.dao.entity.BaseResult; +import org.apache.polaris.core.persistence.dao.entity.EntityResult; +import org.apache.polaris.core.persistence.resolver.PolarisResolutionManifestCatalogView; +import org.apache.polaris.service.catalog.io.FileIOFactory; +import org.apache.polaris.service.task.TaskExecutor; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class PolarisGenericTableCatalog { Review Comment: Yes, it totally depends on the definition of the operation. For example, if the listGenericTable APIs is defined to list all tables (includes iceberg), then it will also need to access the iceberg tables to get all tables. However, that is just an example, it is not what is designed to do for the current MVP. Extend the responsibilities of the APIs will definitely need some careful design, especially about how it interacts with the current iceberg endpoints, otherwise it could be really confusing to users. Recently I have encountered a problem when integrating with glue catalog, where we expect the iceberg endpoint only return iceberg tables, but it actually returns tables with other formats, which is causing a lot of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
