sfc-gh-ygu commented on code in PR #1147:
URL: https://github.com/apache/polaris/pull/1147#discussion_r1996445310
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntityType.java:
##########
@@ -32,9 +32,10 @@ public enum PolarisEntityType {
CATALOG_ROLE(5, CATALOG, true, false),
NAMESPACE(6, CATALOG, false, true),
// generic table is either a view or a real table
- TABLE_LIKE(7, NAMESPACE, false, false),
+ ICEBERG_TABLE_LIKE(7, NAMESPACE, false, false),
TASK(8, ROOT, false, false),
- FILE(9, TABLE_LIKE, false, false);
+ FILE(9, ICEBERG_TABLE_LIKE, false, false),
+ GENERIC_TABLE(10, NAMESPACE, false, false);
Review Comment:
> In larger context, having only type + sub-type seems rather awkward for a
type system.
Agreed with @dimas-b for this one. The only option now is to add another
layer of subtype in entity properties.
I like the new entity type that it can easily use the subtype for `Delta`,
`Parquet`, etc. From the privilege perspective, do we need another layer on top
of both `ICEBERG_TABLE_LIKE` and `GENERIC_TABLE` to group them somehow? I'm
also open to other options in terms of grouping privileges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
